Skip to content

bench: add missing method name in benchmark description#11155

Merged
kgryte merged 1 commit intostdlib-js:developfrom
mvanhorn:osc/11151-fix-benchmark-of-name
Mar 27, 2026
Merged

bench: add missing method name in benchmark description#11155
kgryte merged 1 commit intostdlib-js:developfrom
mvanhorn:osc/11151-fix-benchmark-of-name

Conversation

@mvanhorn
Copy link
Contributor

@mvanhorn mvanhorn commented Mar 26, 2026 •
edited
Loading

Summary

Adds missing :of: method name to the benchmark format string in @stdlib/array/little-endian-factory/benchmark/benchmark.of.js.

Changes

Line 55: '%s:len=5' -> '%s:of:len=5'

The first benchmark in the file correctly uses '%s:of' (line 36), but the second benchmark was missing the method name segment.

Closes #11151

This contribution was developed with AI assistance (Claude Code).

@mvanhorn @claude
fix: add missing method name in little-endian-factory benchmark
22445bd 
The benchmark name format string was missing the :of: method name
segment. Changed '%s:len=5' to '%s:of:len=5' to match the convention
used by the first benchmark in the same file and other factory
benchmarks.

Closes stdlib-js#11151

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 26, 2026

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 26, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 26, 2026

Coverage Report

Package Statements Branches Functions Lines
array/little-endian-factory $\color{red}334/566$
$\color{green}+59.01%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{red}0/4$
$\color{green}+0.00%$ 		$\color{red}334/566$
$\color{green}+59.01%$

The above coverage report was generated for the changes in this PR.

@github-actions github-actions bot mentioned this pull request Mar 26, 2026
Open
@batpigandme
Copy link
Member

batpigandme commented Mar 26, 2026

Hi,

Just like in your other PR, we need the snippet suggested by the stdlib-bot to be added to the PR description

-   [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

Thanks!

@mvanhorn
Copy link
Contributor Author

mvanhorn commented Mar 26, 2026

Added to the description. Thanks for the heads up.

@kgryte kgryte changed the title fix: add missing method name in little-endian-factory benchmark bench: add missing method name in benchmark description Mar 27, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. review: 5 and removed Needs Review A pull request which needs code review. labels Mar 27, 2026
This was referenced Mar 27, 2026
Closed
Closed
@kgryte kgryte merged commit 7fb96a3 into stdlib-js:develop Mar 27, 2026
109 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit df7737d)

4 participants

@mvanhorn @stdlib-bot @batpigandme @kgryte